-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update future feature flags default table #1091
Conversation
Thanks to the pointer @afrittoli ! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Yongxuanzhang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| Feature stability level | Default | | ||
| ----------------------- | -------- | | ||
| Stable | Enabled; Cannot be disabled once the flag is removed (after deprecation) | | ||
| Beta | Disabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current docs says beta feature are enabled by default, we are going to change it right?
https://github.com/tektoncd/pipeline/blob/8123d6332245008983aabe1dc910a63bd2c6f261/api_compatibility_policy.md?plain=1#L120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we are not. Some of the discussion at: tektoncd/pipeline#6948 (comment). The table is for new features only. And the existing beta features guarded by enable-api-fields
will still be turned on by default.
I intend to clarify so at the doc updates via tektoncd/pipeline#7090 (which is currently blocked by tektoncd/pipeline#6941).
2d0f8bc
to
caa01e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update
/approve
This commit updates the table of new feature flags and their default values at each stability level.
caa01e1
to
1343953
Compare
@QuanZhang-William: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, dibyom, vdemeester, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wondering why this is not merged yet? |
Thanks for the reminder! And yes this shall be ready to go. |
/lgtm |
This commit updates the table of new feature flags and their default values at each stability level.