Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tektoncd/pipeline to version 0.9.0 #501

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

piyush-garg
Copy link
Contributor

Changes

This will bump the version of tektoncd pipeline
dep to 0.9.0 and other dep like kubernetes
and knative.dev/pkg

This will fix the changes required for pipeline 0.9.0
like removing the deprecatedServiceAccount field and
related implementations and test. Chanes in describe command
to handle the pipelineRef and resourceRef

Fix #429

Fix #498

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Bump tektoncd/pipeline to version 0.9.0

This will bump the version of tektoncd pipeline
dep to 0.9.0 and other dep like kubernetes
and knative.dev/pkg

Fix tektoncd#498
This will fix the changes required for pipeline 0.9.0
like removing the deprecatedServiceAccount field and
related implementations and test. Chanes in describe command
to handle the pipelineRef and resourceRef

Fix tektoncd#429
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 88.5% 89.2% 0.8
pkg/cmd/task/start.go 86.8% 86.7% -0.1
pkg/helper/validate/validate.go 94.1% 96.2% 2.0

@chmouel
Copy link
Member

chmouel commented Dec 4, 2019

nice work 💪

@chmouel
Copy link
Member

chmouel commented Dec 4, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@vdemeester vdemeester added this to the 0.6.0 🐨 milestone Dec 4, 2019
@danielhelfand
Copy link
Member

I know there is a scheduled release for 0.9.1 that is going to be released. Would it make sense to hold off and upgrade then?

@chmouel
Copy link
Member

chmouel commented Dec 4, 2019

@danielhelfand Perhaps better to merge often and quickly for the sake of iterations would be easier to pintpoint issue with 0.9.1 if there is any? (even there really shouldnt)

@@ -58,6 +58,36 @@ func TaskRefExists(spec v1alpha1.TaskRunSpec) string {
return spec.TaskRef.Name
}

// Check if PipelineRef exists on a PipelineRunSpec. Returns empty string if not present.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@tekton-robot tekton-robot merged commit 26aaa1e into tektoncd:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
6 participants