-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tektoncd/pipeline to version 0.9.0 #501
Conversation
This will bump the version of tektoncd pipeline dep to 0.9.0 and other dep like kubernetes and knative.dev/pkg Fix tektoncd#498
This will fix the changes required for pipeline 0.9.0 like removing the deprecatedServiceAccount field and related implementations and test. Chanes in describe command to handle the pipelineRef and resourceRef Fix tektoncd#429
The following is the coverage report on pkg/.
|
nice work 💪 |
/lgtm |
I know there is a scheduled release for 0.9.1 that is going to be released. Would it make sense to hold off and upgrade then? |
@danielhelfand Perhaps better to merge often and quickly for the sake of iterations would be easier to pintpoint issue with 0.9.1 if there is any? (even there really shouldnt) |
@@ -58,6 +58,36 @@ func TaskRefExists(spec v1alpha1.TaskRunSpec) string { | |||
return spec.TaskRef.Name | |||
} | |||
|
|||
// Check if PipelineRef exists on a PipelineRunSpec. Returns empty string if not present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This will bump the version of tektoncd pipeline
dep to 0.9.0 and other dep like kubernetes
and knative.dev/pkg
This will fix the changes required for pipeline 0.9.0
like removing the deprecatedServiceAccount field and
related implementations and test. Chanes in describe command
to handle the pipelineRef and resourceRef
Fix #429
Fix #498
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes