-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direnv support with boilerplate #2175
Conversation
This add a .envrc file that will be used by direnv to setup the environment for the project if `direnv` is enabled. It also adds a `.env.sample` to give an example of what it could be useful for. And it adds `.env` to gitignore to make sure people do not commit their specific environment configurations. Signed-off-by: Vincent Demeester <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I already have a .envrc for some of my specific things on cli, and why this needs to be in repo ? |
Could it move in the |
what kind of shared task do you have in mind? isn't pre-commit something more appropriate if it's lint/checks/code related? |
|
We discussed this a bit offline and it's probably a bad idea for security (since it bypass the |
Changes
This add a .envrc file that will be used by direnv to setup the environment for the project if
direnv
is enabled. It also adds a.env.sample
to give an example of what it could be useful for. And it adds.env
to gitignore to make sure people do not commit their specific environment configurations./cc @tektoncd/cli-maintainers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes