Bump golangci-lint to v1.54.2 #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
vinamra28
force-pushed
the
bump-golangci-lint-1.54.2
branch
2 times, most recently
from
225436a
to
7e69bda
Compare
|
can we please do the change in release pipeline too |
vinamra28
force-pushed
the
bump-golangci-lint-1.54.2
branch
from
7e69bda
to
7bcf993
Compare
|
/lgtm maybe take the opportunity to add more linters ! (we have a few of them in PaaC) |
tekton-robot
added
lgtm
vinamra28
force-pushed
the
bump-golangci-lint-1.54.2
branch
from
3312e38
to
7bcf993
Compare
Fixes couple of lint issues: - G101: Potential hardcoded credentials - G601: Implicit memory aliasing in for loop. Temporarily disabling: - G602: Potentially accessing slice out of bounds as this is a known false positive and can be tracked at securego/gosec#1005 Also bump golangci-lint version in release pipeline Signed-off-by: vinamra28 <[email protected]> Add logger to identify the pod failure
vinamra28
force-pushed
the
bump-golangci-lint-1.54.2
branch
from
7bcf993
to
b607aa8
Compare
|
/test pull-tekton-cli-integration-tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes couple of lint issues:
Temporarily disabling:
false positive and can be tracked at false positive of g602 with maps securego/gosec#1005
Also bump golangci-lint version in release pipeline
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes