Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt for changes in TEP-0100 #1985

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Adapt for changes in TEP-0100 #1985

merged 1 commit into from
Apr 13, 2023

Conversation

zregvart
Copy link
Contributor

Changes

The EmbeddedStatus feature flag was removed in[1], with that the TaskRuns field is no longer available in the v1beta1.PipelineRun's Status. This adapts the test utilizing that field and allows the upgrade to Tekton Pipeline v0.45.0.

The PipelineRunHasFailed function in test/builder/validate.go doesn't seem to be used, so I removed it rather than adapting it to use ChildReferences.

I've tested this by running make with Tekton Pipeline at v0.44.0 and at v0.45.0.

[1] tektoncd/pipeline#6049

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@zregvart
Adapt for changes in TEP-0100
029ad7f 
The `EmbeddedStatus` feature flag was removed in[1], with that the
`TaskRuns` field is no longer available in the `v1beta1.PipelineRun`'s
`Status`. This adapts the test utilizing that field and allows the
upgrade to Tekton Pipeline v0.45.0.

The `PipelineRunHasFailed` function in `test/builder/validate.go`
doesn't seem to be used, so I removed it rather than adapting it to use
`ChildReferences`.

I've tested this by running `make` with Tekton Pipeline at v0.44.0 and
at v0.45.0.

[1] tektoncd/pipeline#6049
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 12, 2023
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2023
@tekton-robot
Copy link
Contributor

Hi @zregvart. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2023
@piyush-garg
Copy link
Contributor

Thanks for the PR
/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@piyush-garg
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
zregvart added a commit to zregvart/tkn-cli that referenced this pull request Apr 12, 2023
@zregvart
Remove support for pullRequest resource
16c1980 
Tekton Pipeline in v0.45.0 removed support for the `pullRequest`[1]
resource. In accordance with TEP-74[2]. This removes support for it in
the CLI as well.

An alternative might be to redeclare in CLI or restore the
`v1alpha1.PipelineResourceTypePullRequest` constant in Tekton Pipeline.

I've tested this by running `make` with Tekton Pipeline at v0.44.0 and
at v0.45.0.

With this and PR#1985[3] it should be possible to upgrade to Tekton
Pipeline to v0.45.0.

[1] tektoncd/pipeline#6011
[2] https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md
[3] tektoncd#1985
@zregvart zregvart mentioned this pull request Apr 12, 2023
Closed
4 tasks
vinamra28
vinamra28 reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot tekton-robot merged commit a6a215c into tektoncd:main Apr 13, 2023
@zregvart zregvart deleted the pr/TEP-0100-fix branch April 13, 2023 08:31
@vinamra28 vinamra28 mentioned this pull request Apr 16, 2023
Closed
vinamra28 added a commit that referenced this pull request May 10, 2023
@vinamra28
New version v0.31.0
7af15e9 
#1981 | [vinamra28] Bump versions in README to v0.30.1 | 2023/04/11-07:18
#1983 | [pratap0007] Remove PipelineResource support in clustertask | 2023/04/13-07:24
#1985 | [Zoran Regvart] Adapt for changes in TEP-0100 | 2023/04/13-07:58
#1984 | [pratap0007] Remove PipelineResource support in task | 2023/04/13-09:42
#1988 | [pratap0007] Remove PipelineResource support in pipeline | 2023/04/13-14:54
#1987 | [Basavaraju G] remove e2e pipeline resource tests | 2023/04/13-18:48
#1991 | [dependabot[bot]] Bump k8s.io/apimachinery from 0.26.3 to 0.26.4 | 2023/04/14-07:26
#1992 | [dependabot[bot]] Bump k8s.io/client-go from 0.25.8 to 0.25.9 | 2023/04/14-08:08
#1993 | [vinamra28] Use own FakeClock func instead of from library | 2023/04/14-08:44
#1993 | [dependabot[bot]] Bump github.com/jonboulle/clockwork from 0.3.0 to 0.4.0 | 2023/04/14-08:44
null | [pratap0007] Remove resource command | 2023/04/14-09:36
null | [pratap0007] Remove input and output resource in clustertask describe command | 2023/04/14-11:38
null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.25.8 to 0.25.9 | 2023/04/14-12:34
null | [Eng Zer Jun] Replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` | 2023/04/16-13:44
null | [pratap0007] Remove all occurrence of PipelineResource and move pipeline to 0.46.0 in CI | 2023/04/17-15:06
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/04/19-20:14
null | [Luiz Carvalho] Update to cosign v2 | 2023/04/19-21:38
null | [pratap0007] Remove docs related to PipelineResource | 2023/04/20-10:34
null | [dependabot[bot]] Bump k8s.io/api from 0.26.1 to 0.26.4 | 2023/04/22-04:36
null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.6.1 to 1.6.3 | 2023/04/22-05:12
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/04/22-05:46
null | [pratap0007] Remove PipelineResource in the describe command test | 2023/04/25-19:40
null | [PuneetPunamiya] Remove flags from chains payload command as not used | 2023/05/02-10:40
null | [pratap0007] Remove default value info for true flag in delete command | 2023/05/02-13:16
null | [pratap0007] Upgrade golangci version to v1.52.2 and fix lint errors | 2023/05/04-13:26
null | [pratap0007] Bump tektoncd/pipeline to 0.47.0 manually | 2023/05/05-21:34
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/05/06-04:04
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/05/06-04:40
null | [dependabot[bot]] Bump golang.org/x/term from 0.7.0 to 0.8.0 | 2023/05/06-12:58
null | [pratap0007] Fix tkn pr/tr delete command for keep flag | 2023/05/06-16:44
null | [dependabot[bot]] Bump github.com/tektoncd/chains | 2023/05/06-17:24
null | [Piyush Garg] Bump cosign to v2.0.2 | 2023/05/07-06:44
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/05/08-16:42
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/05/08-18:08
null | [dependabot[bot]] Bump github.com/tektoncd/hub from 1.12.1 to 1.13.0 | 2023/05/09-08:08

Signed-off-by: vinamra28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zregvart @tekton-robot @piyush-garg @vinamra28