Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang 1.17.3 in contrib/tkn-image/Dockerfile #1669

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

mattysweeps
Copy link
Contributor

Changes

  • Bump the default GOLANG_VERSION to 1.17.3
    The image was not building with the existing default value, 1.13.* due
    to the use of embeded files

TESTED:

docker build --file=contrib/tkn-image/Dockerfile --target=tkn --tag tkn:latest .

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

- Bump the default GOLANG_VERSION to 1.17.3
  The image was not building with the existing default value, 1.13.* due
  to the use of embeded files

TESTED:
```
docker build --file=contrib/tkn-image/Dockerfile --target=tkn --tag tkn:latest .
```
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mattysweeps / name: Matthew Broomfield (cf6affe)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2022
@tekton-robot
Copy link
Contributor

Hi @mattysweeps. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2022
@piyush-garg
Copy link
Contributor

@mattysweeps Currently the Dockerfile in this repo is not getting used, the one which is getting used is https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@bendory
Copy link
Contributor

bendory commented Aug 19, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2022
@bendory
Copy link
Contributor

bendory commented Aug 23, 2022

/lgtm
but robot doesn't like me yet 😿

@tekton-robot
Copy link
Contributor

@bendory: changing LGTM is restricted to collaborators

In response to this:

/lgtm
but robot doesn't like me yet 😿

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@bendory
Copy link
Contributor

bendory commented Aug 24, 2022

/retest-required

@piyush-garg
Copy link
Contributor

/retest
/lgtm

@tekton-robot tekton-robot merged commit 5cd499f into tektoncd:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants