-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use golang 1.17.3 in contrib/tkn-image/Dockerfile #1669
Conversation
- Bump the default GOLANG_VERSION to 1.17.3 The image was not building with the existing default value, 1.13.* due to the use of embeded files TESTED: ``` docker build --file=contrib/tkn-image/Dockerfile --target=tkn --tag tkn:latest . ```
|
Hi @mattysweeps. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mattysweeps Currently the Dockerfile in this repo is not getting used, the one which is getting used is https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
@bendory: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
/retest |
Changes
The image was not building with the existing default value, 1.13.* due
to the use of embeded files
TESTED:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes