Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force static linking by setting CGO_ENABLED=0. #1660

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Force static linking by setting CGO_ENABLED=0. #1660

merged 1 commit into from
Jul 27, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Jul 27, 2022

Changes

Fixes #1659

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests no functional change
  • Run the code checkers with make check no golang changes
  • Regenerate the manpages, docs and go formatting with make generated no changes
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Debian packaging updated to create a static-linked binary.

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 27, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2022
@bendory bendory marked this pull request as ready for review July 27, 2022 15:09
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@tekton-robot tekton-robot requested a review from vinamra28 July 27, 2022 15:09
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @chmouel

@tekton-robot tekton-robot requested a review from chmouel July 27, 2022 15:32
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@chmouel
Copy link
Member

chmouel commented Jul 27, 2022

i think debian packaging linter is not going to like static binary, were you able to generate a binary package out of this change?

@bendory
Copy link
Contributor Author

bendory commented Jul 27, 2022

i think debian packaging linter is not going to like static binary, were you able to generate a binary package out of this change?

Yes -- but as noted, I'm running on a Google-internal Debian distribution; IDK what differences you will see when you compile in the wild.

@chmouel
Copy link
Member

chmouel commented Jul 27, 2022

perhaps ubuntu ppa upload farm has a linters which is not allowing static binaries.

i guess the only way to know that is to make a release, so i guess that would be the surprise for next time :) /cc @tektoncd/cli-collaborators

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 68cbdbd into tektoncd:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] change PPA packaging to static linking
4 participants