-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force static linking by setting CGO_ENABLED=0. #1660
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @chmouel
i think debian packaging linter is not going to like static binary, were you able to generate a binary package out of this change? |
Yes -- but as noted, I'm running on a Google-internal Debian distribution; IDK what differences you will see when you compile in the wild. |
perhaps ubuntu ppa upload farm has a linters which is not allowing static binaries. i guess the only way to know that is to make a release, so i guess that would be the surprise for next time :) /cc @tektoncd/cli-collaborators /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #1659
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes testsno functional changeRun the code checkers withnomake check
golang
changesRegenerate the manpages, docs and go formatting withno changesmake generated
See the contribution guide
for more details.
Release Notes