-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add different timeout flags for Pipeline start cmd #1642
Conversation
Skipping CI for Draft Pull Request. |
c5d5c77
to
5ab346b
Compare
@pradeepitm12 @piyush-garg @vdemeester @chmouel
and the help command is now
do let me know if this looks good to you |
5ab346b
to
7ab6dcd
Compare
7ab6dcd
to
8521a77
Compare
ac63404
to
f2b413b
Compare
/retest |
With Pipelines release v0.36.0, Timeouts was moved out of feature flags and existing Timeout was deprecated. This PR updates the timeouts flags of `tkn pipeline start` to allow user to pass the different timeouts for `Pipeline`, `PipelineTask` and `FinallyTask` before starting a `Pipeline` using CLI. Signed-off-by: vinamra28 <[email protected]>
f2b413b
to
f03df98
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
2 similar comments
/retest |
/retest |
Changes
With Pipelines release v0.36.0, Timeouts was moved out of feature flags
and existing Timeout was deprecated.
This PR updates the timeouts flags of
tkn pipeline start
to allow userto pass the different timeouts for
Pipeline
,PipelineTask
andFinallyTask
before starting aPipeline
using CLI.closes #1561
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes