Add function comments to pkg/actions, tweaks to Makefile and linting #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
|
/assign @vdemeester |
tekton-robot
added
the
size/XXL
vdemeester
approved these changes
Jun 24, 2022
tekton-robot
added
the
approved
abayer
force-pushed
the
pkg-actions-function-comments
branch
2 times, most recently
from
50c3ac5 to
9c454e1
Compare
|
/retest |
abayer
force-pushed
the
pkg-actions-function-comments
branch
from
9c454e1 to
738dc5d
Compare
Assuming this is accepted, this is the first in a likely long series of PRs from me refactoring, cleaning up code, adding function comments, gradually adding linter rules to match what we've got in Pipeline along with addressing issues those linter rules find, etc. Signed-off-by: Andrew Bayer <[email protected]>
abayer
force-pushed
the
pkg-actions-function-comments
branch
from
738dc5d to
c3a6c75
Compare
|
/cc @vinamra28 @tektoncd/cli-maintainers |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Assuming this is accepted, this is the first in a likely long series of PRs from me refactoring, cleaning up code, adding function comments, gradually adding linter rules to match what we've got in Pipeline along with addressing issues those linter rules find, etc.
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes