Fix tkn chains signature/payload by version bump
#1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekton Chains looks at PipelineResources AND *IMAGE_URL,
*IMAGE_DIGEST in results to sign and attest relevant outputs.
Prior to this commit, only *IMAGE_URL was considered as a valid output
while looking up TaskRuns, this commit fixes that.
Prior behavior when *IMAGE_URL was not present:
```
$ tkn chain signature build-push-run-output-image-p229w
sync /dev/stderr: invalid argument
{"level":"info","ts":1654512978.599003,"caller":"tekton/tekton.go:115","msg":"Retrieving signature on TaskRun default/build-push-run-output-image-p229w"}
{"level":"info","ts":1654512978.5990307,"caller":"tekton/tekton.go:86","msg":"Retrieving annotation \"chains.tekton.dev/signature-taskrun-6e2f020b-7d50-4022-8064-049680f72d32\" on TaskRun default/build-push-run-output-image-p229w"}
No signatures found for taskrun build-push-run-output-image-p229w
```
New behavior,
```
$ ./tkn chain signature build-push-run-output-image-p229w
Retrieving signature on TaskRun default/build-push-run-output-image-p229w
Retrieving annotation "chains.tekton.dev/signature-taskrun-6e2f020b-7d50-4022-8064-049680f72d32" on TaskRun default/build-push-run-output-image-p229w
[0E _ϹlYP3: [email protected]@sS!5:shy6CTI#2]
```
This commit bumps the chains dependency version to the commit that contains
this fix upstream.
tekton-robot
added
the
release-note
tekton-robot
added
size/S
vinamra28
approved these changes
Jun 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tekton Chains looks at PipelineResources AND *IMAGE_URL,
*IMAGE_DIGEST in results to sign and attest relevant outputs.
Prior to this commit, only *IMAGE_URL was considered as a valid output
while looking up TaskRuns, this commit fixes that.
Prior behavior when *IMAGE_URL was not present:
New behavior,
This commit bumps the chains dependency version to the commit that contains
this fix upstream.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.