Bump chains to v0.9.0 #1580
Merged
Bump chains to v0.9.0 #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XXL
concaf
commented
Jun 2, 2022
concaf
commented
Jun 2, 2022
Comment on lines
+358
to
+362
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc => go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.20.0 | ||
| go.opentelemetry.io/otel => go.opentelemetry.io/otel v0.20.0 | ||
| go.opentelemetry.io/otel/sdk => go.opentelemetry.io/otel/sdk v0.20.0 |
There was a problem hiding this comment.
@pradeepitm12 @piyush-garg I could get this working with require somehow, when I added these as indirect imports. Either I am missing something, or these are being imported by multiple indirect dependencies due to which replace is the right thing to do !?!? let's talk about this
|
/hold |
tekton-robot
added
the
do-not-merge/hold
concaf
force-pushed
the
concaf/bump/chains-version-new
branch
3 times, most recently
from
e8d9831 to
7ed15e9
Compare
To upgrade to the versions selected by go 1.16:
go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
go mod tidy -compat=1.17
xerrors.Errorf is deprecated; as of Go 1.13, fmt.Errorf should be used instead
concaf
force-pushed
the
concaf/bump/chains-version-new
branch
2 times, most recently
from
5f69168 to
9b1b442
Compare
concaf
force-pushed
the
concaf/bump/chains-version-new
branch
from
9b1b442 to
6b6cd12
Compare
|
It is green 🎉 |
tekton-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bumps Chains version to 0.9.0
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes