Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency bumps #1570

Merged
merged 2 commits into from
Jun 1, 2022
Merged

dependency bumps #1570

merged 2 commits into from
Jun 1, 2022

Conversation

pradeepitm12
Copy link
Contributor

This bumps
Go - > 1.17
Pipeline -> 0.35.1
Triggers -> 0.20.0

Signed-off-by: Pradeep Kumar [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 20, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 20, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pradeepitm12 / name: PRADEEP KUMAR (bcc8e29)

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 20, 2022
@pradeepitm12
dep bumps
bcc8e29 
This bumps
Go - > 1.17
Pipeline -> 0.35.1
Triggers -> 0.20.0

Signed-off-by: Pradeep Kumar <[email protected]>
@pradeepitm12 pradeepitm12 force-pushed the depbumps-pipelinev0.35.1-triggersv0.20.0 branch from 945f139 to bcc8e29 Compare May 20, 2022 06:38
@pradeepitm12 pradeepitm12 mentioned this pull request May 20, 2022
Closed
4 tasks
@pradeepitm12
Copy link
Contributor Author

Need to fix go test ./cmd/...

@piyush-garg piyush-garg added this to the 0.24.0 milestone May 23, 2022
@pradeepitm12 pradeepitm12 force-pushed the depbumps-pipelinev0.35.1-triggersv0.20.0 branch 2 times, most recently from 2ebe17d to 2f83061 Compare May 30, 2022 12:23
@pradeepitm12
Copy link
Contributor Author

This tektoncd/plumbing#1085 should help

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member 

--------------------------------------
---- Checking that go code builds ----
--------------------------------------
package github.com/tektoncd/cli/third_party/VENDOR-LICENSE/github.com/hashicorp/go-plugin
	third_party/VENDOR-LICENSE/github.com/hashicorp/go-plugin/grpc_broker.go:14:2: use of internal package github.com/hashicorp/go-plugin/internal/plugin not allowed
---------------------------------------------------
---- Checking autogenerated code is up-to-date ----
---------------------------------------------------
go mod tidy: go.mod file indicates go 1.17, but maximum supported version is 1.16

@vdemeester vdemeester closed this May 30, 2022
@vdemeester vdemeester reopened this May 30, 2022
@vdemeester
Copy link
Member

oh.. still on 1.16... 🤔

@pradeepitm12
Copy link
Contributor Author

/retest

@pradeepitm12 pradeepitm12 force-pushed the depbumps-pipelinev0.35.1-triggersv0.20.0 branch 5 times, most recently from 9ca5ff5 to 8fe92bb Compare May 31, 2022 13:56
@pradeepitm12 pradeepitm12 force-pushed the depbumps-pipelinev0.35.1-triggersv0.20.0 branch from 8fe92bb to 573d967 Compare May 31, 2022 14:02
@vdemeester vdemeester closed this Jun 1, 2022
@vdemeester vdemeester reopened this Jun 1, 2022
@tekton-robot
Copy link
Contributor

@pradeepitm12: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-cli-go-coverage 573d967 link /test pull-tekton-cli-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@concaf concaf mentioned this pull request Jun 1, 2022
Closed
4 tasks
@pradeepitm12
Copy link
Contributor Author

/retest
as the pr got merged tektoncd/plumbing#1087

@pradeepitm12
Copy link
Contributor Author

/retest

@pradeepitm12 pradeepitm12 reopened this Jun 1, 2022
@vdemeester
Copy link
Member

/skip

@vdemeester
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@vdemeester
Copy link
Member

/override pull-tekton-cli-go-coverage

@vdemeester
Copy link
Member

I'll probably force merge this by hand once the builds are done as pull-tekton-cli-go-coverage will be gone on new builds

@vdemeester vdemeester merged commit 5647bc9 into tektoncd:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pradeepitm12 @vdemeester @tekton-robot @piyush-garg