Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set created time for bundle image #1563

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: set created time for bundle image #1563

merged 1 commit into from
May 11, 2022

Conversation

digglife
Copy link
Contributor

@digglife digglife commented May 7, 2022

Changes

The Created field of bundle image config was set as zero time, which
is 0001-01-01T00:00:00Z. With this commit, it will be set
as the time when the bundle is created.

fixes: #1562

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

set the created time for bundle image correctly.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 7, 2022
@tekton-robot
Copy link
Contributor

Hi @digglife. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2022
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/bundle/builder.go 72.4% 71.9% -0.5

@digglife
Copy link
Contributor Author

digglife commented May 9, 2022

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@piyush-garg
Copy link
Contributor

/retest

4 similar comments
@digglife
Copy link
Contributor Author

digglife commented May 9, 2022

/retest

@digglife
Copy link
Contributor Author

/retest

@vdemeester
Copy link
Member

/retest

@vinamra28
Copy link
Member

/retest

@vdemeester
Copy link
Member

I think the PR needs a rebase for the integration-test to be fixed 👼🏼

@digglife
fix: set created time for bundle image
214978a 
The `Created` field of bundle image config was set as zero time, which
is `0001-01-01T00:00:00Z`. With this commit, it will be set as the time
when the bundle is created.

fixes: tektoncd#1562
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/bundle/builder.go 72.4% 71.9% -0.5

@digglife
Copy link
Contributor Author

/retest

1 similar comment
@vinamra28
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 947a78d into tektoncd:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@vinamra28 vinamra28 Awaiting requested review from vinamra28

Assignees

@piyush-garg piyush-garg

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tkn bundle Created & Metadata.LastTagTime zeroed out.
5 participants
@digglife @tekton-robot @vdemeester @piyush-garg @vinamra28