Add -o name to pipeline start #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -o name to start to simply output the pipelinerun that has been started. Tests are a bit of pain, it's nearly impossible (or i don't know how) to fakeout, since I can't get a generate pipelinerunt to come out we just test emptyness, it's okay tho because it tests the flags i guess 🙃. This has been reformated with latest gofumpt https://github.com/mvdan/gofumpt let me know if that confuses anyone and would like me to break that change. Co-authored-by: Lan Liang <[email protected]> Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot
added
do-not-merge/release-note-label-needed
|
The following is the coverage report on the affected files.
|
|
@liangyuanpeng I have added you as co-author since you were on the original param in #1433 let me know if it's ok for you. |
vdemeester
approved these changes
Mar 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -o name to start to simply output the pipelinerun that has been
started.
Tests are a bit of pain, it's nearly impossible (or i don't know how) to
fakeout, since I can't get a generate pipelinerunt to come out we just
test emptyness, it's okay tho because it tests the flags i guess 🙃.
This has been reformated with latest gofumpt
https://github.com/mvdan/gofumpt let me know if that confuses anyone and
would like me to break that change.
Co-authored-by: @liangyuanpeng
Release Notes