Make chains namespace configurable #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
|
/hold |
tekton-robot
added
the
do-not-merge/hold
piyush-garg
force-pushed
the
refac_chains
branch
from
db383e5 to
48a05da
Compare
concaf
suggested changes
Mar 9, 2022
piyush-garg
force-pushed
the
refac_chains
branch
from
48a05da to
323431f
Compare
This makes chains namespace configurable with new flag chains-namespace where you can specify in which namespace the chains is configured, by default it is tekton-chains Do refacotring in chains cmd code Update docs
This will bump chains to v0.8.0 and hub to v1.7.0
piyush-garg
force-pushed
the
refac_chains
branch
from
323431f to
a3a0458
Compare
vdemeester
approved these changes
Mar 9, 2022
tekton-robot
added
the
approved
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
@concaf: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes chains namespace configurable with new flag
chains-namespace where you can specify in which namespace
the chains is configured, by default it is tekton-chains
Do refactoring in chains cmd code
Update docs
Bump chains and hub deps
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes