Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds chains version in output of tkn version command #1509

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Adds chains version in output of tkn version command #1509

merged 1 commit into from
Mar 1, 2022

Conversation

mansi103
Copy link
Contributor

@mansi103 mansi103 commented Feb 16, 2022 •
edited
Loading

Closes #1485
Signed-off-by: mansi103 [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 16, 2022
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2022
@tekton-robot
Copy link
Contributor

Hi @mansi103. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2022
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022
@vinamra28
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 71.6% 69.7% -1.8
pkg/version/version.go 89.5% 88.0% -1.5

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 71.6% 69.7% -1.8
pkg/version/version.go 89.5% 89.3% -0.2

@mansi103
Copy link
Contributor Author

/cc @piyush-garg

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@vinamra28
Copy link
Member

/lgtm

pradeepitm12
pradeepitm12 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@tekton-robot tekton-robot merged commit cef2a64 into tektoncd:main Mar 1, 2022
piyush-garg added a commit that referenced this pull request Mar 9, 2022
@piyush-garg
New version v0.23.0
ec7cf5e 
#1498 | [Pradeep Kumar] update tkn v0.22.0 | 2022/02/01-22:04
#1499 | [Daniel Helfand] update tkn chocolatey package to v0.22.0 | 2022/02/02-10:17
#1503 | [Chmouel Boudjnah] Use ubuntu-rolling to build package | 2022/02/03-10:17
#1505 | [Shubham] Make `vendor` a PHONY target | 2022/02/07-10:50
#1500 | [Chmouel Boudjnah] Add export option for pipelinerun | 2022/02/15-12:01
#1484 | [mansi103] Checked existence of resources before deletion | 2022/02/16-13:46
#1513 | [tomonight] pass rest config when create tkn clients,fix the default QPS is to low(QPS is 5),can improve the concurrent | 2022/02/28-09:14
#1514 | [Piyush Garg] Bump deps of pipeline and triggers | 2022/02/28-13:53
#1509 | [mansi103] Adds chains version in output of tkn version command | 2022/03/01-12:52
#1440 | [Rémy Greinhofer] Add Chains management command | 2022/03/03-15:01
null | [Vincent Demeester] Fix vendoring | 2022/03/03-15:01
null | [Vincent Demeester] Temporary disable linting tarball package | 2022/03/03-15:01
null | [jbpratt] remove unnecessary filepath join | 2022/03/04-08:13
null | [jbpratt] gofmt -w test/e2e/* | 2022/03/04-08:27
null | [jbpratt] replace t.Errorf %w with %v | 2022/03/04-09:17
null | [PuneetPunamiya] Bump Tekton Hub CLI to latest | 2022/03/04-10:37
null | [Pradeep Kumar] fix missing Cursor with interactive start commands | 2022/03/04-12:13
null | [Chmouel Boudjnah] Fix tektoncd docs installation instructions | 2022/03/08-08:08
null | [Piyush Garg] Make chains namespace configurable | 2022/03/09-09:29
null | [Piyush Garg] Bump chains and hub deps | 2022/03/09-09:29

Signed-off-by: Piyush Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@sthaha sthaha Awaiting requested review from sthaha

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Chains version in tkn version
5 participants
@mansi103 @tekton-robot @vinamra28 @piyush-garg @pradeepitm12