Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EventListener describe and logs cmd to be compatible with v1beta1 #1455

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Update EventListener describe and logs cmd to be compatible with v1beta1 #1455

merged 2 commits into from
Oct 1, 2021

Conversation

vinamra28
Copy link
Member

Update Eventlistener describe and logs cmd to be compatible with
v1beta1 as well as v1alpha1.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 30, 2021
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 30, 2021
@vinamra28
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/describe.go Do not exist 81.2%
pkg/cmd/eventlistener/list.go Do not exist 86.7%
pkg/cmd/eventlistener/logs.go Do not exist 48.8%
pkg/eventlistener/eventlistener.go 70.6% 66.7% -3.9

@vinamra28
Update EventListener describe command
f75438f 
This will update eventlistener describe cmd to
be compatible with both v1alpha1 and v1beta1.

Signed-off-by: vinamra28 <[email protected]>
@vinamra28
Update EventListener logs command
4afb94c 
This will update eventlistener logs cmd to
be compatible with both v1alpha1 and v1beta1

Signed-off-by: vinamra28 <[email protected]>
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/eventlistener/describe.go Do not exist 81.2%
pkg/cmd/eventlistener/list.go Do not exist 86.7%
pkg/cmd/eventlistener/logs.go Do not exist 48.8%
pkg/eventlistener/eventlistener.go 70.6% 72.0% 1.4

@vinamra28
Copy link
Member Author

/retest

@vinamra28
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@tekton-robot tekton-robot merged commit 71a183d into tektoncd:main Oct 1, 2021
@vinamra28 vinamra28 deleted the el-v1beta1-describe branch October 1, 2021 09:50
@piyush-garg piyush-garg mentioned this pull request Oct 1, 2021
Closed
4 tasks
@rolfedh
Copy link

rolfedh commented Oct 25, 2021

@vinamra28 (working with @piyush-garg?) would you please restate the release note using terms that are more user-friendly?
For an example of what this looks like, please see https://github.com/openshift/openshift-docs/pull/37369/files and https://deploy-preview-37369--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes#new-features-1-6_op-release-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinamra28 @tekton-robot @savitaashture @rolfedh @piyush-garg