Tkn bundle list split yamls #2091
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Milestone
Comments
Lima118
added
the
kind/feature
|
/assign |
lcarva
added a commit
to lcarva/cli
that referenced
this issue
Aug 13, 2024
Some printers contain an internal state. The YAMLPrinter, for example, tracks how many objects have been printed. When it prints an object, and it is not the first one to be printed, it prints the YAML document separator, `---`. If a new printer is used when printing each object, then the YAMLPrinter always considers that it is printing the first object. This causes the YAML objects to be muddled together. This commit makes it so a printer is re-used when printing multiple objects. For conformity, this is also done when a single object is expected to be printed, e.g. get or describe. Fixes tektoncd#2091 Signed-off-by: Luiz Carvalho <[email protected]>
lcarva
added a commit
to lcarva/cli
that referenced
this issue
Aug 13, 2024
Some printers contain an internal state. The YAMLPrinter, for example, tracks how many objects have been printed. When it prints an object, and it is not the first one to be printed, it prints the YAML document separator, `---`. If a new printer is used when printing each object, then the YAMLPrinter always considers that it is printing the first object. This causes the YAML objects to be muddled together. This commit makes it so a printer is re-used when printing multiple objects. For conformity, this is also done when a single object is expected to be printed, e.g. get or describe. Fixes tektoncd#2091 Signed-off-by: Luiz Carvalho <[email protected]>
|
/unassign @RohanGlitched as @lcarva has raised the PR |
|
@piyush-garg: GitHub didn't allow me to assign the following users: lcarva. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
It would be a useful feature for us when we use tkn bundle list on an OCI image, that contains multiple tasks/pipelines the output would be a valid merged yaml file. Right now it does not separate the yamls with ---. Therefor if we use tkn bundle list, then pipe it to kubectl apply it only applies the last task/pipeline, not all of them.
Use case
If it would be implemented we could use bundle to bundle a Pipeline with all of its Tasks into one OCI Image, then we could version control our Pipelines and could easily deploy them from CI with one tkn bundle list piped into kubectl apply.
The text was updated successfully, but these errors were encountered: