Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release pipeline for ghcr.io #1220

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

afrittoli
Copy link
Member

Changes

To reduce CI spending, we're in the process of moving all new release to ghcr.io - tektoncd/plumbing#2157

This prepares the release pipeline for that switch (which will require a PR in the plumbing repo).

This PR also aligns the pipeline with some other small improvements already adopted by other projects:

  • use remote resolution for tasks
  • only run build and tests when requested - it will be disabled by default on nightly builds

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

To reduce CI spending, we're in the process of moving all new
release to ghcr.io - tektoncd/plumbing#2157

This prepares the release pipeline for that switch (which will
require a PR in the plumbing repo).

This PR also aligns the pipeline with some other small improvements
already adopted by other projects:
- use remote resolution for tasks
- only run build and tests when requested - it will be disabled by
  default on nightly builds

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2024
@@ -65,37 +71,43 @@ spec:
env:
- name: "PROJECT_ROOT"
value: "$(workspaces.source.path)"
- name: CONTAINER_REGISTY_CREDENTIALS
- name: CONTAINER_REGISTRY_CREDENTIALS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@tekton-robot tekton-robot merged commit 6bcfe64 into tektoncd:main Oct 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants