Buildpacks pipeline v0.2

[bradbeck]

Changes

The recent update to Tekton Pipeline v0.36.0 (https://github.com/tektoncd/pipeline/releases/tag/v0.36.0) appears to cause an error when executing the build tasks in the buildpacks pipeline.

invalid input params for task buildpacks: param types don't match the user-specified type: [ENV_VARS]

Changing the default value of ENV_VARS in the pipeline to the following appears to resolve the problem:

    - name: ENV_VARS
      type: array
      description: Environment variables to set during _build-time_.
      default: [""]

This appears to be related to changes made to allow parameter propagation:

✨ TEP-0107: Implement Parameter Propagation (tektoncd/pipeline#4845)
Parameters are propagated in embedded specifications without mutations.

Discovered as part of buildsec/frsca#237

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Follows the authoring recommendations
• Includes docs (if user facing)
• Includes tests (if functionality of task changed or new task added)
• Commit messages follow commit message best practices
• Complies with [Catalog Organization TEP][TEP], see [example]. Note [An issue has been filed to automate this validation][validation]

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide
for more details.

[tekton-robot]

Hi @bradbeck. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jromero]

I may need to look into the changes further the TAP explicitly mentions "When using an inlined spec, parameters from the parent PipelineRun will be propagated to any inlined specs without needing to be explicitly defined.".

I'm concerned that this proposed change actually doesn't pass the ENV_VARS to the actual tasks.

Looking at the latest docs, I wonder if the actual fix is to change the syntax from:

        - name: ENV_VARS
          value: ["$(params.ENV_VARS)"]

to:

        - name: ENV_VARS
          value: ["$(params.ENV_VARS[*])"]

[bradbeck]

        - name: ENV_VARS
          value: ["$(params.ENV_VARS[*])"]

I still get the following error when using that syntax:

invalid input params for task buildpacks: param types don't match the user-specified type: [ENV_VARS]

[dibyom]

/ok-to-test

[chmouel]

/lgtm

[tekton-robot]

Catlin Output

FILE: task/github-set-status/0.4/github-set-status.yaml
WARN : Step "set-status" uses image "$(params.IMAGE)" that contains variables; skipping validation

Catlin script lint Output

WARN : step: github-set-status is not using #!/usr/bin/env 

[jromero]

Hmmm... I just ran a test locally (Pipeline version: v0.37.1) and the environment variables are not being passed to the tasks.

I'll investigate further but my suspicion stands.

[tekton-robot]

Catlin Output

FILE: task/github-set-status/0.4/github-set-status.yaml
WARN : Step "set-status" uses image "$(params.IMAGE)" that contains variables; skipping validation

Catlin script lint Output

WARN : step: github-set-status is not using #!/usr/bin/env 

[dibyom]

/lgtm

[tekton-robot]

Catlin Output

FILE: task/github-set-status/0.4/github-set-status.yaml
WARN : Step "set-status" uses image "$(params.IMAGE)" that contains variables; skipping validation

Catlin script lint Output

WARN : step: github-set-status is not using #!/usr/bin/env 

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment