Add jib-maven 0.3 with certficate support for registry #691

piyush-garg · 2021-04-07T13:14:36Z

This will add jib-maven 0.3 version with support for providing cert file
to talk to insecure registry

Fix #686

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes docs (if user facing)
Includes tests (if functionality of task changed or new task added)
Commit messages follow commit message best practices
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide
for more details.

tekton-robot · 2021-04-07T13:16:08Z

Catlin Output

FILE: task/jib-maven/0.3/jib-maven.yaml
WARN : Step "build-and-push" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation

vinamra28 · 2021-04-07T13:19:29Z

/retest

chmouel

Diff for others to look at :

https://paste.gg/p/anonymous/49c36f4075224ea3b242c7003d2fef7d

chmouel · 2021-04-07T13:17:58Z

task/jib-maven/0.3/jib-maven.yaml

+    script: |
+      #!/bin/sh
+
+      [[ -f  /etc/ssl/certs/$(params.CACERTFILE) ]] && \


$(workspaces.sscertdir.path) ?

In case of scenarios, like user did not specify workspace but the operator is mounting the cert in taskrun pod, then this is not getting applied, so made it by explicitly specifying the path

chmouel · 2021-04-07T13:18:36Z

task/jib-maven/0.3/jib-maven.yaml

+    workingDir: $(workspaces.source.path)/$(params.DIRECTORY)
+    env:
+    - name: HOME
+      value: /workspace


Do you need to do this ? This usually can get problematic to redefine HOME generally speaking...

This I just made the same as the previous version. If this is not required I can remove it. Task working fine without this also c @chanseokoh

PR which added this #407

chmouel · 2021-04-07T13:21:07Z

task/jib-maven/0.3/tests/pre-apply-task-hook.sh

+TMD=$(mktemp -d)
+
+# Generate SSL Certificate
+openssl req -newkey rsa:4096 -nodes -sha256 -keyout "${TMD}"/ca.key -x509 -days 365 \


we should probably make that as default for add_sidecar_registry or add it as a add_sidecar_secure_registry if that's problematics for other tasks...

Sure, I can add a new func for secure registry and use that in all tasks, maybe will handle it in different PR with changes in all tasks

I have done the changes in the same PR now

vinamra28 · 2021-04-07T14:07:38Z

message: 'Pipeline jib-maven-0-3/jib-maven-test-pipeline can''t be Run; it contains
        Tasks that don''t exist: Couldn''t retrieve Task "git-clone": clustertasks.tekton.dev
        "git-clone" not found'

reason for failure

tekton-robot · 2021-04-07T16:17:23Z

Catlin Output

FILE: task/jib-maven/0.3/jib-maven.yaml
WARN : Step "build-and-push" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation

task/jib-maven/0.3/README.md

This will add jib-maven 0.3 version with support for providing cert file to talk to insecure registry Fix tektoncd#686

piyush-garg · 2021-04-08T07:18:14Z

/test pull-catalog-catlin-lint

vinamra28

/lgtm

tekton-robot · 2021-04-08T07:49:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chmouel · 2021-04-08T08:41:50Z

/lgtm

thanks

chmouel · 2021-04-08T08:42:34Z

There is the documentation to update tho to add that new add_sidecar_secure_registry, any chances you can update it ?

/hold

afrittoli · 2021-04-08T09:31:58Z

/test pull-catalog-catlin-lint

afrittoli · 2021-04-08T09:50:18Z

/test pull-catalog-catlin-lint

tekton-robot · 2021-04-08T09:50:56Z

Catlin Output

FILE: task/jib-maven/0.3/jib-maven.yaml
WARN : Step "build-and-push" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation

Created a function to run secure sidecar registry with cert and calling that function from all tests to remove duplication

tekton-robot · 2021-04-08T10:19:25Z

Catlin Output

FILE: task/jib-maven/0.3/jib-maven.yaml
WARN : Step "build-and-push" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.MAVEN_IMAGE)" that contains variables; skipping validation

chmouel · 2021-04-08T10:21:59Z

/hold cancel

/lgtm

thanks

piyush-garg · 2021-04-08T10:46:06Z

/test pull-tekton-catalog-integration-tests

tekton-robot · 2021-04-08T10:46:28Z

catlin.txt

piyush-garg · 2021-04-08T11:39:45Z

/test pull-tekton-catalog-integration-tests

piyush-garg · 2021-04-08T11:40:08Z

Error

Unable to connect to the server: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

tekton-robot · 2021-04-08T11:40:08Z

catlin.txt

vinamra28 · 2021-04-08T12:25:52Z

/retest

tekton-robot requested review from a user and vinamra28 April 7, 2021 13:14

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2021

chmouel reviewed Apr 7, 2021

View reviewed changes

piyush-garg force-pushed the add_jib-maven_0.3 branch from 05acf9d to aaaeaf4 Compare April 7, 2021 16:15

vinamra28 reviewed Apr 8, 2021

View reviewed changes

task/jib-maven/0.3/README.md Outdated Show resolved Hide resolved

piyush-garg force-pushed the add_jib-maven_0.3 branch from aaaeaf4 to 7dcb644 Compare April 8, 2021 06:00

Add jib-maven 0.3 with certficate support for registry

5edf40d

This will add jib-maven 0.3 version with support for providing cert file to talk to insecure registry Fix tektoncd#686

piyush-garg force-pushed the add_jib-maven_0.3 branch from 7dcb644 to 3688c2b Compare April 8, 2021 07:04

piyush-garg force-pushed the add_jib-maven_0.3 branch from 3688c2b to 579f9bc Compare April 8, 2021 07:33

vinamra28 reviewed Apr 8, 2021

View reviewed changes

tekton-robot assigned vinamra28 Apr 8, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021

vdemeester approved these changes Apr 8, 2021

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021

tekton-robot assigned chmouel Apr 8, 2021

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2021

Refactor in e2e script and pre-apply func

20299cf

Created a function to run secure sidecar registry with cert and calling that function from all tests to remove duplication

piyush-garg force-pushed the add_jib-maven_0.3 branch from 579f9bc to 20299cf Compare April 8, 2021 10:18

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021

tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 8, 2021

piyush-garg mentioned this pull request Apr 8, 2021

Bump Community Task Versions for OpenShift tektoncd/operator#279

Merged

3 tasks

tekton-robot merged commit c2547bd into tektoncd:main Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add jib-maven 0.3 with certficate support for registry #691

Add jib-maven 0.3 with certficate support for registry #691

piyush-garg commented Apr 7, 2021

tekton-robot commented Apr 7, 2021

vinamra28 commented Apr 7, 2021

chmouel left a comment

chmouel Apr 7, 2021

piyush-garg Apr 7, 2021 •

edited

Loading

chmouel Apr 7, 2021

piyush-garg Apr 7, 2021

piyush-garg Apr 8, 2021

chmouel Apr 7, 2021

piyush-garg Apr 8, 2021 •

edited

Loading

piyush-garg Apr 8, 2021

vinamra28 commented Apr 7, 2021

tekton-robot commented Apr 7, 2021

piyush-garg commented Apr 8, 2021

vinamra28 left a comment

tekton-robot commented Apr 8, 2021

chmouel commented Apr 8, 2021

chmouel commented Apr 8, 2021

afrittoli commented Apr 8, 2021

afrittoli commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

chmouel commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

vinamra28 commented Apr 8, 2021

Add jib-maven 0.3 with certficate support for registry #691

Add jib-maven 0.3 with certficate support for registry #691

Conversation

piyush-garg commented Apr 7, 2021

Submitter Checklist

tekton-robot commented Apr 7, 2021

vinamra28 commented Apr 7, 2021

chmouel left a comment

Choose a reason for hiding this comment

chmouel Apr 7, 2021

Choose a reason for hiding this comment

piyush-garg Apr 7, 2021 • edited Loading

Choose a reason for hiding this comment

chmouel Apr 7, 2021

Choose a reason for hiding this comment

piyush-garg Apr 7, 2021

Choose a reason for hiding this comment

piyush-garg Apr 8, 2021

Choose a reason for hiding this comment

chmouel Apr 7, 2021

Choose a reason for hiding this comment

piyush-garg Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

piyush-garg Apr 8, 2021

Choose a reason for hiding this comment

vinamra28 commented Apr 7, 2021

tekton-robot commented Apr 7, 2021

piyush-garg commented Apr 8, 2021

vinamra28 left a comment

Choose a reason for hiding this comment

tekton-robot commented Apr 8, 2021

chmouel commented Apr 8, 2021

chmouel commented Apr 8, 2021

afrittoli commented Apr 8, 2021

afrittoli commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

chmouel commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

piyush-garg commented Apr 8, 2021

tekton-robot commented Apr 8, 2021

vinamra28 commented Apr 8, 2021

piyush-garg Apr 7, 2021 •

edited

Loading

piyush-garg Apr 8, 2021 •

edited

Loading