Add tkn to catalog. #155
Add tkn to catalog. #155
Conversation
tekton-robot
added
the
size/M
|
|
||
| ### Parameters | ||
|
|
||
| name | description | default |
There was a problem hiding this comment.
Should we do the same for the rest ? (We need templates and a small script like ./create-task that would create the folder and put some skeleton in there)
There was a problem hiding this comment.
Yes! See #7, which proposes generating READMEs from the underlying Task definition.
We actually have an outreachy intern who just started who will be looking into this. So stay tuned!
tkn/tkn.yaml
Outdated
| - name: ARGS | ||
| type: array | ||
| description: tkn CLI arguments to run | ||
| default: ["help"] |
There was a problem hiding this comment.
Should we have no default for the task, thus making the ARGS a required argument.
| params: | ||
| - name: tkn-image | ||
| description: tkn CLI container image to run this task | ||
| default: gcr.io/tekton-releases/dogfooding/tkn |
There was a problem hiding this comment.
We should tag a stable release for the default.
There was a problem hiding this comment.
AFAIK this is the best we have right now. Once tektoncd/cli#497 is resolved, we can update this URL.
There was a problem hiding this comment.
Yes, my apologies. I opened that issue after seeing this pr and became aware from it that we need an official image.
Adds a Task to the catalog for the [Tekton CLI](https://github.com/tektoncd/cli).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Adds a Task to the catalog for the Tekton CLI.
Fixes #154
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.