address null purpose check in FileClient GetFiles (Azure#44923)

tejasm-microsoft · Jul 22, 2024 · d644f5c · d644f5c
1 parent ea8a662
commit d644f5c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/sdk/openai/Azure.AI.OpenAI/CHANGELOG.md b/sdk/openai/Azure.AI.OpenAI/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### Bugs Fixed
 
+- Removed an inappropriate null check in `FileClient.GetFiles()` (azure-sdk-for-net 44912)
+
 ### Other Changes
 
 ## 2.0.0-beta.2 (2024-06-14)

diff --git a/sdk/openai/Azure.AI.OpenAI/assets.json b/sdk/openai/Azure.AI.OpenAI/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/openai/Azure.AI.OpenAI",
-  "Tag": "net/openai/Azure.AI.OpenAI_fc99a87ba7"
+  "Tag": "net/openai/Azure.AI.OpenAI_b36dc0424a"
 }
diff --git a/sdk/openai/Azure.AI.OpenAI/src/Custom/Files/AzureFileClient.Protocol.cs b/sdk/openai/Azure.AI.OpenAI/src/Custom/Files/AzureFileClient.Protocol.cs
@@ -67,17 +67,13 @@ public override async Task<ClientResult> GetFileAsync(string fileId, RequestOpti
     [EditorBrowsable(EditorBrowsableState.Never)]
     public override ClientResult GetFiles(string purpose, RequestOptions options)
     {
-        Argument.AssertNotNullOrEmpty(purpose, nameof(purpose));
-
         using PipelineMessage message = CreateGetFilesRequestMessage(purpose, options);
         return ClientResult.FromResponse(Pipeline.ProcessMessage(message, options));
     }
 
     [EditorBrowsable(EditorBrowsableState.Never)]
     public override async Task<ClientResult> GetFilesAsync(string purpose, RequestOptions options)
     {
-        Argument.AssertNotNullOrEmpty(purpose, nameof(purpose));
-
         using PipelineMessage message = CreateGetFilesRequestMessage(purpose, options);
         return ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false));
     }

diff --git a/sdk/openai/Azure.AI.OpenAI/tests/FileTests.cs b/sdk/openai/Azure.AI.OpenAI/tests/FileTests.cs
@@ -31,4 +31,12 @@ public async Task CanUploadAndDeleteFiles()
         bool deleted = await client.DeleteFileAsync(file);
         Assert.IsTrue(deleted);
     }
+
+    [RecordedTest]
+    public async Task CanListFiles()
+    {
+        FileClient client = GetTestClient();
+        OpenAIFileInfoCollection files = await client.GetFilesAsync();
+        Assert.That(files, Has.Count.GreaterThan(0));
+    }
 }