-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for playlist edit #76
Conversation
Any volunteers who would like to test this PR? @tehkillerbee @2e0byo @fmarzocca I have been doing playlist edits for the past few days without issues, tested both from ncmpcpp, Iris and M.A.L.P. However, all these clients are also compatible with the limitations of the current implementation - only support for "Add to playlist" (i.e. append at the end, not in the middle), and swapping only works with adjacent tracks so we can get away with a DELETE followed by a POST. I'd be interested to know how things work with other clients though. |
@blacklight Definitely. I can only test with Iris, as this is what I currently. If there are other clients you suggest testing with, I'll give it a try. |
@blacklight First initial tests:
|
@tehkillerbee I think 4 is just a limitation of iris in general. I'm up for testing this, though I too only use iris! I'll pull it down in a bit. |
After further testing, I noticed the playlists provided as m3u files do show up automatically. So I wonder how they are populated in Iris. Tidal playlists only show up if added manually or when browsing them individually |
@tehkillerbee I think some work is required on mopidy-iris side as well. At a first look, it seems that Iris inspect the An entry exists for Spotify - one should probably be added for Tidal as well. Besides that, playlist editing, creation and deletion seems to work quite well over MPD. I mostly use the mopidy-mpd backend to connect to MPD clients, and I have tested playlist edit mostly through ncmpcpp and mpc command-line commands. mopidy-mobile also works by the way, since it's a bit less opinionated than Iris about what playlists can actually be edited. |
@blacklight Since this is mainly an Iris Issue, I think we can merge this PR and add it to the Iris todo list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with isort errors
Closes #75
Known limitations:
POST
request to the playlist item URL with thetoIndex
argument, but I haven't found anything like that in thetidalapi
package