Use rhts-report-result alias instead of tmt-report-result for reporting beakerlib subresults #3372
+87
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was troubleshooting why the logs for beakerlib phases (aka tmt subresults) are not saved by
tmt-report-result
script and the reason is the following.The beakerlib calls the command in
BEAKERLIB_COMMAND_REPORT_RESULT
variable in the following way:See the implementation of
rlReport
here:Suppose we use
tmt-report-result
as the value forBEAKERLIB_COMMAND_REPORT_RESULT
(as a script name). In that case, the script will not be compatible with the third$logfile
positional argument - it will just ignore it because it accepts the logfile provided only by the-o/--outputFile
option by default.We want to use the
rhts-report-result
alias because of a compatibility layer implemented by thetmt-report-result
script itself. If the script gets called withrhts-report-result
name, it will accept the third positional argument as alogfile
:tmt/tmt/steps/execute/scripts/tmt-report-result
Line 101 in e7cf41d
Related to:
Pull Request Checklist