Add tpm as a new hardware specification key
#1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
added
specification
|
As discussed on the hacking session, let's start with a simple implementation for which we have a tangible use case. @kkaarreell, please review to confirm this covers your use case well. Thanks. |
|
LGTM for the start. |
kkaarreell
approved these changes
Oct 27, 2022
|
@psss I'd propose making corresponding changes to https://github.com/teemtee/tmt/blob/main/tmt/schemas/provision/hardware.yaml in this patch. |
psss
force-pushed
the
psss-hardware-tpm
branch
2 times, most recently
from
2163f6f
to
7f09887
Compare
Let's start with a simple implementation allowing to specify the desired version, use extra dictionary level to allow future extensions if needed. Fix #1191.
psss
force-pushed
the
psss-hardware-tpm
branch
from
7f09887
to
6f65cc1
Compare
Good point, json schema updated in 6f65cc1. |
happz
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start with a simple implementation allowing to specify the desired version, use extra dictionary level to allow future extensions if needed.
Fix #1191.