feat: add TDS8.0 Support for tedious #1522

MichaelSun90 · 2023-02-08T22:39:51Z

This PR added logics for supporting TDS8.0.
Co-authored with @arthurschreiber
Co-authored with @mShan0

* fix type check for `options.encrypt` * syntax fix

codecov · 2023-02-15T22:45:16Z

Codecov Report

Merging #1522 (c3e8b67) into master (07cac40) will increase coverage by 0.15%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   80.65%   80.80%   +0.15%     
==========================================
  Files          92       92              
  Lines        4663     4684      +21     
  Branches      857      864       +7     
==========================================
+ Hits         3761     3785      +24     
+ Misses        628      621       -7     
- Partials      274      278       +4

Files Changed	Coverage Δ
src/tds-versions.ts	`100.00% <ø> (ø)`
src/connection.ts	`65.92% <73.68%> (+0.61%)`	⬆️

... and 2 files with indirect coverage changes

…into NewTLSSupport

…wTLSSupport

ci: add latest build of sql server 2022

arthurschreiber · 2023-03-28T11:36:00Z

.github/workflows/nodejs.yml

@@ -193,8 +193,7 @@ jobs:
        Push-Location C:\temp

        Invoke-WebRequest -Uri https://download.microsoft.com/download/c/c/9/cc9c6797-383c-4b24-8920-dc057c1de9d3/SQL2022-SSEI-Dev.exe -OutFile SQL2022-SSEI-Dev.exe
-        ./SQL2022-SSEI-Dev.exe /ACTION=Download /MEDIAPATH=C:\temp /MEDIATYPE=CAB /QUIET
-
+        Start-Process -Wait -FilePath ./SQL2022-SSEI-Dev.exe -ArgumentList /ACTION=Download, /MEDIAPATH=C:\temp, /MEDIATYPE=CAB, /QUIET
        Start-Process -Wait -FilePath ./SQLServer2022-DEV-x64-ENU.exe -ArgumentList /qs, /x:setup

        .\setup\setup.exe /q /ACTION=Install /INSTANCENAME=MSSQLSERVER /FEATURES=SQLEngine /UPDATEENABLED=0 /SQLSVCACCOUNT='NT SERVICE\MSSQLSERVER' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS /SQLCOLLATION=SQL_Latin1_General_CP1_CI_AS /USESQLRECOMMENDEDMEMORYLIMITS


TODO: We can use /SECURITYMODE='SQL' to enable mixed authentication on installation, and use /SAPWD='...' to set the password. That would allow us to skip changing these settings (and the server restart).

…latest cumulative update file

arthurschreiber · 2023-03-30T10:34:00Z

src/connection.ts

+            secureContext: secureContext,
+            servername: this.config.options.serverName ? this.config.options.serverName : this.config.server,
+          };
+          const encryptsocket = tls.connect(encryptOptions, () => {


What will happen if someone connects using strict encryption to a SQL Server instance that does not support it?
How do we need to handle that, and how do we signal to the user that something is wrong? How do we help them understand what is wrong?

If user uses a strict to connect to a SQL server instance that does not support it, a socket error will be returned as : " Client network socket disconnected before secure TLS connection was established"
Server side message:
"The login packet used to open the connection is structurally invalid; the connection has been closed. Please contact the vendor of the client library. [CLIENT: 172.28.192.1]
"
what do you think that we consume this message internally, and throw a custom error with a bit more information, so we can guide user through this

arthurschreiber · 2023-03-30T10:34:26Z

src/connection.ts

+            this.transitionTo(this.STATE.SENT_PRELOGIN);
+          });
+
+          console.log('using TDS 8.0 strict TLS encryption');


I believe this might be some leftover log output.

arthurschreiber · 2023-03-30T10:34:41Z

src/connection.ts

+          socket.on('error', (error) => { this.socketError(error); });
+          socket.on('close', () => { this.socketClose(); });
+          socket.on('end', () => { this.socketEnd(); });
+          socket.setKeepAlive(true, KEEP_ALIVE_INITIAL_DELAY);

-        this.messageIo = new MessageIO(socket, this.config.options.packetSize, this.debug);
-        this.messageIo.on('secure', (cleartext) => { this.emit('secure', cleartext); });
+          this.messageIo = new MessageIO(socket, this.config.options.packetSize, this.debug);
+          this.messageIo.on('secure', (cleartext) => { this.emit('secure', cleartext); });

-        this.socket = socket;
+          this.socket = socket;

-        this.closed = false;
-        this.debug.log('connected to ' + this.config.server + ':' + this.config.options.port);
+          this.closed = false;
+          this.debug.log('connected to ' + this.config.server + ':' + this.config.options.port);

-        this.sendPreLogin();
-        this.transitionTo(this.STATE.SENT_PRELOGIN);
+          this.sendPreLogin();
+          this.transitionTo(this.STATE.SENT_PRELOGIN);


Can we remove this duplication?

…wTLSSupport

…vailable.

github-actions · 2023-07-20T15:19:43Z

🎉 This PR is included in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MichaelSun90 and others added 5 commits July 19, 2022 13:04

feat: add support for TDS8.0

4b27035

Merge branch 'master' into NewTLSSupport

96c88cb

fix: fix type check for options.encrypt (#1517)

60c1a38

* fix type check for `options.encrypt` * syntax fix

chore: Add logic for read secure context

bf32f85

chore: update the PR based on the comments

e458d12

MichaelSun90 and others added 19 commits February 15, 2023 14:59

chore: add logic for read secure context

2165a2a

chore: update the PR based on the comments

3a9213a

Merge branch 'NewTLSSupport' of https://github.com/tediousjs/tedious …

f654831

…into NewTLSSupport

Merge branch 'master' into NewTLSSupport

39b1379

chore: changes based on comments

b31c287

Merge branch 'NewTLSSupport' of https://github.com/tediousjs/tedious …

eabc9d5

…into NewTLSSupport

chore: add tests and fixed some minor issue

0fcbe8a

chore: remove it.only from test

ef108d6

test: add additional encrypt config unit tests (#1525)

a448262

Merge branch 'master' into NewTLSSupport

a6ffebf

Add extendedKeyUsage option.

fee6ee7

Try some other options.

30f0ccd

Merge branch 'master' of https://github.com/tediousjs/tedious into Ne…

7891302

…wTLSSupport

Add some config debug output.

cbe4089

Ensure proper line endings.

76a146a

ci: add latest build of sql server 2022

2252a43

Merge pull request #1530 from tediousjs/mark-update-windows-ci-build

88ef29f

ci: add latest build of sql server 2022

wait for files to finish download

7818752

enable updates

53dd486

arthurschreiber reviewed Mar 28, 2023

View reviewed changes

arthurschreiber and others added 4 commits March 28, 2023 23:54

ci: revert to download box files directly, also download and install …

e5b4c6f

…latest cumulative update file

ci: fix update download path

d5f2bdb

ci: fix starting the sql server install

81c52a2

chore: fix test for other protocol versions

f675c79

arthurschreiber reviewed Mar 30, 2023

View reviewed changes

MichaelSun90 and others added 11 commits April 6, 2023 10:06

chore: code style change and error handling

04c76a7

Merge branch 'master' of https://github.com/tediousjs/tedious into Ne…

c955670

…wTLSSupport

Fix incorrect merge conflict resolution.

3b8074d

test: rework to skip if TDS 8.0 is not available

f2e45ad

Merge branch 'master' into NewTLSSupport

a6d414a

fix: remove the unecessary error output form connection-test

c2aa47f

Only check sys.dm_os_host_info on SQL Server versions where it is a…

47bd587

…vailable.

Merge branch 'master' into NewTLSSupport

d579439

chore: lint issue

20ef404

chore: lint issue for socket

c20367b

chore: connection to certain db

a9524dc

MichaelSun90 force-pushed the NewTLSSupport branch 2 times, most recently from 33078d9 to a9524dc Compare June 30, 2023 17:20

MichaelSun90 added 3 commits July 17, 2023 11:26

Merge branch 'master' into NewTLSSupport

9d52330

Merge branch 'master' into NewTLSSupport

1859352

chore: remove the db constrain

c3e8b67

MichaelSun90 merged commit c02e30f into master Jul 19, 2023

github-actions bot added the released label Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add TDS8.0 Support for tedious #1522

feat: add TDS8.0 Support for tedious #1522

MichaelSun90 commented Feb 8, 2023

codecov bot commented Feb 15, 2023 •

edited

Loading

arthurschreiber Mar 28, 2023

arthurschreiber Mar 30, 2023

MichaelSun90 Mar 30, 2023

arthurschreiber Mar 30, 2023

arthurschreiber Mar 30, 2023

github-actions bot commented Jul 20, 2023

feat: add TDS8.0 Support for tedious #1522

feat: add TDS8.0 Support for tedious #1522

Conversation

MichaelSun90 commented Feb 8, 2023

codecov bot commented Feb 15, 2023 • edited Loading

Codecov Report

arthurschreiber Mar 28, 2023

Choose a reason for hiding this comment

arthurschreiber Mar 30, 2023

Choose a reason for hiding this comment

MichaelSun90 Mar 30, 2023

Choose a reason for hiding this comment

arthurschreiber Mar 30, 2023

Choose a reason for hiding this comment

arthurschreiber Mar 30, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2023

codecov bot commented Feb 15, 2023 •

edited

Loading