Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node v12 to build matrix #870

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Add Node v12 to build matrix #870

merged 4 commits into from
Nov 5, 2019

Conversation

willmorgan
Copy link
Collaborator

@willmorgan willmorgan commented May 18, 2019

What this does:

Adds Node v12 to the build matrix for testing, also adds x86/x64 tests, although not sure if the latter is really needed in 2019 😉

@willmorgan
Copy link
Collaborator Author

Node v12 was made available nearly a month ago, but it isn't yet on AppVeyor. Shame.

appveyor/ci#2921

I'll rework.

@dhensby
Copy link
Collaborator

dhensby commented May 18, 2019

By the looks of things we are only running tests against LTS versions, but v12 is not LTS (yet) so do we want to add it when we don't test any other non-LTS version and appveyor doesn't support it?

@willmorgan
Copy link
Collaborator Author

v12 is not LTS (yet) so do we want to add it when we don't test any other non-LTS version and appveyor doesn't support it?

Odd numbered versions of Node won't ever make it to LTS whereas even numbers will.

Node releases versions destined to be LTS a few months before to get them completely stable before designating them as the LTS version.

https://nodejs.org/en/about/releases/

I think it's worth putting this in. Everyone else in the ecosystem seems to be aliasing v12 to latest at the moment.

@dhensby
Copy link
Collaborator

dhensby commented May 20, 2019

I think it's worth putting this in.

Sure, but only once we can actually get it green :)

@dhensby dhensby merged commit 1416c0b into master Nov 5, 2019
@dhensby dhensby deleted the node-12-tests branch November 5, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants