Make tectonic -Zhelp work
#929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll lose some coverage but this opens my PDF viewer every time I run "cargo test" and that's pretty annoying.
This is definitely a hack, most notably because `tectonic -Z help` still won't work. So be it. Closes tectonic-typesetting#923.
|
Windows builds were having some Cranko dirtiness problem so I've gone ahead and updated the CI to use my now-standard three-stage workflow. This will also be useful to have in place if/when we start depositing to Zenodo and registering DOIs, since that workflow requires a single release-commit creation stage. |
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
- Coverage 45.75% 45.75% -0.01%
==========================================
Files 147 147
Lines 61396 61403 +7
==========================================
+ Hits 28091 28093 +2
- Misses 33305 33310 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Here we update to what's now my standard for Cranko-powered builds: a three-stage process, with Prep, Build&Test, and Deploy. The proximate motivation is that it looks like maybe the Windows builds are erroring out because Cranko is detecting Git submodules as dirty files, but it's a better system anyway. In particular, if/when we start registering on Zenodo and getting DOIs, we need a single prep stage so that all of the builds can see and use the same DOI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #923.
tectonic -Zhelp -is enough, and this is a hack, but it should give a nice little quality-of-life improvement.Also, fix a long-standing thing that's bothered me and stop my PDF viewer from popping open every time I run the test suite.