Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle rework #1218

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Bundle rework #1218

merged 6 commits into from
Sep 21, 2024

Conversation

rm-dr
Copy link
Contributor

@rm-dr rm-dr commented Sep 19, 2024

Re-opening PR, original (#1121) was deleted by branch cleanup.

Our current bundle scheme is causing quite a few bugs. This PR (paired with tectonic-typesetting/tectonic-texlive-bundles#14) resolves many of these by implementing proper search paths in bundles.

These changes are not be breaking. Zip and tar bundles may still be used, but they can no longer be created.

Changes in this PR:

  • A new bundle format (see Huge rewrite, many fixes tectonic-texlive-bundles#14)
  • File search paths (also documented in the bundle repo)
  • Bundle autodetection from url (--web-bundle has been removed, and --bundle now handles both URLs and paths)
  • Bundle caching rework (invisible to the user, but cleans up code)
  • Cache reorganization
  • Bundle-building code is now included in Tectonic as tectonic bundle create

Most changes in this PR are in the bundles crate. Changes in other files are usually minor api side-effects.

@rm-dr rm-dr force-pushed the rmdr/betterbundle branch 4 times, most recently from b716412 to b35e863 Compare September 19, 2024 19:42
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 22.42249% with 1076 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (ac15f72) to head (a5e3416).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...in/tectonic/v2cli/commands/bundle/select/picker.rs 0.00% 292 Missing ⚠️
crates/bundles/src/ttb.rs 0.00% 137 Missing ⚠️
crates/bundles/src/ttb_net.rs 0.00% 108 Missing ⚠️
...in/tectonic/v2cli/commands/bundle/pack/bundlev1.rs 0.00% 102 Missing ⚠️
src/bin/tectonic/v2cli/commands/bundle/actions.rs 0.00% 74 Missing ⚠️
crates/bundles/src/ttb_fs.rs 0.00% 62 Missing ⚠️
crates/bundles/src/cache.rs 69.34% 42 Missing ⚠️
crates/bundles/src/itar.rs 72.09% 36 Missing ⚠️
...tectonic/v2cli/commands/bundle/select/input/tar.rs 0.00% 35 Missing ⚠️
.../bin/tectonic/v2cli/commands/bundle/select/spec.rs 0.00% 29 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage   46.95%   46.20%   -0.75%     
==========================================
  Files         177      188      +11     
  Lines       65197    66146     +949     
==========================================
- Hits        30613    30564      -49     
- Misses      34584    35582     +998     
Flag Coverage Δ
46.20% <22.42%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rm-dr rm-dr marked this pull request as ready for review September 20, 2024 00:16
@rm-dr rm-dr force-pushed the rmdr/betterbundle branch 4 times, most recently from ff94fb2 to d83a399 Compare September 20, 2024 16:02
@rm-dr rm-dr merged commit 51e179f into master Sep 21, 2024
21 of 28 checks passed
@rm-dr rm-dr deleted the rmdr/betterbundle branch September 21, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant