-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bunch more bibtex tests #1039
Conversation
…nes. This should cover most main code paths as well as some particularly useful warning/error paths
These tests aren't just for my bibtex rewriting work - this batch catches another real error due to |
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 44.84% 45.09% +0.25%
==========================================
Files 155 155
Lines 62605 62609 +4
==========================================
+ Hits 28074 28234 +160
+ Misses 34531 34375 -156
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Error appears to be that on Linux, whatever opening a directory returns, it doesn't cause issues - but on Windows, you get |
Great stuff! It looks like the main CI tests passed for the most recent iteration, but GitHub is only showing me the ArXiv check. I'm going to close this and then reopen to retrigger the CI just for completeness. |
Yeah, from what I could tell, I pushed twice too close and the tests ran on the second commit but got attached to the first. Either way, looks happy now. |
This includes tests for crossrefs, multiple cites, and some bad aux lines. This should cover most of the important main code paths as well as some particularly useful warning/error paths.