Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish volume 4, issue 7 (2022-04-19) #323

Merged
merged 8 commits into from
Apr 19, 2022

Conversation

hal-codebot
Copy link
Collaborator

@hal-codebot hal-codebot commented Apr 18, 2022

🤖 Auto-generated issue template. This pull request was initiated by @stationaery.

Checklist

🤓 See the documentation for help.

  • Add initial content to the issue.
  • Upload the header image and any others.
    • 💡 The bot will comment with an upload link.
    • ⚠️ Name the header image correctly before uploading. Near the top of the template, you'll find the expected name. It should look something like vol-3-issue-1-header.jpg. Make sure the file name and extension match the template. Update the template if needed, for example, if you are uploading a png instead.
  • Make final edits and proofread.
  • Approve the pull request when finished. ✅ But, do not merge.
  • Verify that all checks are passing. ✅
    • If status checks are failing, click "Details" next to the failing check. Read the logs and try to address the issue.
  • Add the auto-publish label to automatically merge this tomorrow morning!

@hal-codebot hal-codebot added automated [Bot] An automated task next issue The next issue to be published labels Apr 18, 2022
@hal-codebot
Copy link
Collaborator Author

3 Messages
📖 📷 To add images to this issue, upload them here.
📖 🗑️ To remove images from this issue, find them listed here. Select an image, then click the trash icon.
📖 💡 Add the auto-publish label to automatically publish this issue tomorrow morning.

Generated by 🚫 Danger

@hal-codebot
Copy link
Collaborator Author

hal-codebot commented Apr 18, 2022

2 Messages
📖 📷 To add images to this issue, upload them here.
📖 🗑️ To remove images from this issue, find them listed here. Select an image, then click the trash icon.

Generated by 🚫 Danger

@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for twc-newsletter ready!

Name Link
🔨 Latest commit 045db7d
🔍 Latest deploy log https://app.netlify.com/sites/twc-newsletter/deploys/625e486bc90f960008c19b0c
😎 Deploy Preview https://deploy-preview-323--twc-newsletter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jessesquires
Copy link
Member

Looks like the link checker is broken. Just ignore it. I'll see if I can fix it.

@jessesquires
Copy link
Member

jessesquires commented Apr 18, 2022

Ok, I investigated the link checker stuff. The underlying issue is some deeper infrastructure stuff with GH Actions and the third-party link-checker action we are using.

There's a very involved workaround that I don't have time to implement, so we can just ignore the check for now. (It will not block merging.)

It will eventually get fixed and start working again once the author of the link checker implements the fix/workaround, which is here: gaurav-nelson/github-action-markdown-link-check#133

@stationaery stationaery added the auto-publish [Bot] add this label to automatically publish issues on Friday morning label Apr 19, 2022
@github-actions github-actions bot merged commit e92e61b into master Apr 19, 2022
@github-actions github-actions bot deleted the automated/vol4/issue7-2022-04-19 branch April 19, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-publish [Bot] add this label to automatically publish issues on Friday morning automated [Bot] An automated task next issue The next issue to be published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants