Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved all tests from src/it to src/test/it #10

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bsp/sbt.json
AnshuAg marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"name":"sbt","version":"1.7.1","bspVersion":"2.0.0-M5","languages":["scala"],"argv":["/Users/anshu/Library/Java/JavaVirtualMachines/corretto-11.0.16.1/Contents/Home/bin/java","-Xms100m","-Xmx100m","-classpath","/Users/anshu/Library/Application Support/JetBrains/IdeaIC2024.1/plugins/Scala/launcher/sbt-launch.jar","-Dsbt.script=/opt/homebrew/bin/sbt","xsbt.boot.Boot","-bsp"]}
11 changes: 3 additions & 8 deletions README.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we still installing pre-requisites for batect?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also remove this from README local

Additionally, it would be great to include somewhere with a big heading on how to run Test/IntegrationTest

How can we trigger a single test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed pre-requisites for batect and local readme. I have added the command to run a testClass, not able to find one to run single test though. Also since we move all the tests under IT folder, we can run IntegrationTest via sbt test command only

Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,17 @@ These jobs are using _Spark_ to process larger volumes of data and are supposed

## Pre-requisites

We use [`batect`](https://batect.dev/) to dockerise the tasks in this exercise.
`batect` is a lightweight wrapper around Docker that helps to ensure tasks run consistently (across linux, mac windows).
With `batect`, the only dependencies that need to be installed are Docker and Java >=8. Every other dependency is
managed inside Docker containers. If docker desktop can't be installed then Colima could be used on Mac and Linux.

> **For Windows, docker desktop is the only option for using container to run application otherwise local laptop should be set up.**

Please make sure you have the following installed and can run them

* Docker Desktop or Colima
* Java (11)

> **For Windows, docker desktop is the only option for using container to run application otherwise local laptop should be set up.**

You could use following instructions as guidelines to install Docker or Colima and Java.

```bash
# Install pre-requisites needed by batect
**# Install pre-requisites needed by batect**
# For mac users:
./go.sh install-with-docker-desktop
OR
Expand Down
205 changes: 0 additions & 205 deletions batect

This file was deleted.

Loading