release: v2.5.1 #84
Merged
release: v2.5.1 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: In Progress
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 7 7
Lines 468 468
Branches 84 84
=======================================
Hits 464 464
Misses 4 4 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fix: fix cjs -> esm breakchange, to #82
github-actions
bot
removed
the
Status: In Progress
ljharb
reviewed
Aug 14, 2022
| "exports": { | ||
| "import": "./dist/index.mjs", | ||
| "require": "./dist/index.cjs" | ||
| }, | ||
| "main": "dist/index.mjs", |
There was a problem hiding this comment.
This is still a breaking change for pre-exports node versions. Your "main" must be a .js file that's CJS to avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Base PullRequest
default branch (https://github.com/technote-space/doctoc/tree/main)
Command results
Details:
add path
cli.js -u --packageFile package.json
yarn install
yarn install v1.22.19 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... [4/4] Building fresh packages... success Saved lockfile. Done in 14.97s.yarn upgrade
yarn audit
yarn audit v1.22.19 0 vulnerabilities found - Packages audited: 512 Done in 0.53s.Changed files
Changed 2 files: