print progress in lein release

[saitouena]

justification

This make it easier to rollback release-tasks or complete them by hand.
#2402

• If a release fails, show the user which steps succeeded, which one
  failed, and which ones are left to run.

lein release works like this with this patch.

$ cat project.clj 
;; This is Leiningen's own project configuration. See doc/TUTORIAL.md
;; file as well as sample.project.clj for help writing your own.

(defproject leiningen "2.9.1"
...
  :release-tasks [["echo" "aaa"]
                  ["echo" "bbb"]
                  ["echo" "ccc"]]
  :source-paths ["leiningen-core/src" "src"]
  :eval-in :leiningen)
$ bin/lein release
[ 0 / 3 ] Executing lein echo aaa
aaa
[ 1 / 3 ] Executing lein echo bbb
bbb
[ 2 / 3 ] Executing lein echo ccc
ccc
[ 3 / 3 ] Completed lein release.

[danielcompton]

Thanks for looking at this, I've made some suggestions.

[danielcompton]

I don't think zipmap is the right function for this, it returns a map, not a sequence. Below 8 entries everything will appear to work, but above 8 the order of the entries in the map is not the same as their insertion. I think map would work better here.

Side note, zipmap (and map) can take a finite and infinite sequence and produce a finite map, e.g. (zipmap (range) all-tasks) would also work.

[danielcompton]

I think we might want to start counting at 1 rather than 0 here? When I see 2/3, I think that that is the second task of the three, when it's actually the last one. That would also mean we could avoid having a final "Completed lein release." log message at the end.

[saitouena]

I don't think zipmap is the right function for this, it returns a map, not a sequence.

I should use (map vector (range) release-tasks) here.

I think we might want to start counting at 1 rather than 0 here?

I'm not sure about this. I realized Chrome text search(Ctrl+F) starts from 1, so I'll take your suggestion.

[danielcompton]

task-count might be a better name?

Suggested change

	total-task-count (count all-tasks)]
	task-count (count all-tasks)]

[danielcompton]

Suggested change

	(let [all-tasks (:release-tasks project)
	(let [release-tasks (:release-tasks project)

[danielcompton]

I prefer "running" to "executing" but I think this is mostly a matter of taste.

Suggested change

	(apply main/info (concat ["[" i "/" total-task-count "] Executing lein"] task))
	(apply main/info (concat ["[" i "/" total-task-count "] Running lein"] task))

[saitouena]

@danielcompton I like all your suggestions.
lein release looks like this now.

$ ./bin/lein release
[ 1 / 3 ] Running lein echo aaa
aaa
[ 2 / 3 ] Running lein echo bbb
bbb
[ 3 / 3 ] Running lein echo ccc
ccc

CI failed but ./bin/lein test succeeded in my local environment. Any ideas? It seems that CI is unstable for now. https://circleci.com/gh/technomancy/leiningen

[danielcompton]

This is looking pretty close. I’ll defer to others on whether they’d prefer to see a different format for the log messages. I don’t know if there is a more “Leiningen style” logging format?

[danielcompton]

This might be clearer using format, or possibly just removing the concat and wrapping collection, I don’t think it’s necessary?

[saitouena]

I agree.

[technomancy]

Thanks; this looks great. I can't think of any other comparable output to try to make it more consistent with, so I think we should go with this. I'm looking into the CI failure but it's unrelated to your change.