-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lein deploy does not seem to honor :checksum :ignore #1139
Comments
Checksums are for dependencies you pull down. What error message do you get? What exactly are you running? |
lein deploy clojars => |
I can't reproduce this problem. Maybe this jar has been redeployed to fix the checksums? |
Going to close this; if there's a repro case we can reopen. |
Yeah. Once the server side was patched up for the package in question could
|
I think we do need a command-line option to ignore checksum failure on deployment. In China the |
This seems like a way to address the symptoms instead of the cause of the problem.
|
I found the |
@technomancy Thanks for all the great work you do on leiningen. Are you suggesting that the high latency Internet connections is the problem that needs solving in the case @sunng87 illustrated? |
@okal: I am guessing Phil meant that ignoring the warning is not the right answer – we/Clojars should probably handle incomplete deployments better. I think the best solution would be to ensure that deployments are atomic – either they fail, or they succeed, not end up in some state in between. |
@hypirion Ah, that makes sense. Thanks for clarifying. Atomic deployments would be a great enhancement. |
Atomic deployments to Clojars is clojars/clojars-web#226. I'm pretty sure that is independent of Leiningen. |
I'm having trouble deploying a new snapshot to clojars, no matter what :checksum setting I set it always fail on checksum.
grep'ing through the code I don't see checksum being used in deploy.clj - perhaps it's only used for getting dependencies, not pushing deploys?
The text was updated successfully, but these errors were encountered: