90%: working multiple queues #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #API agnostic for Resque 2 with duck typing on requeue_and_remove | ||
| def reque_single_job(id) | ||
| def requeue_single_job(id, queue) |
There was a problem hiding this comment.
DEATH TO AMERICAN SPELLING!
There was a problem hiding this comment.
Why do you think que is American?
There was a problem hiding this comment.
I stand corrected - Spanish then!
omarqureshi
added a commit
that referenced
this pull request
Jan 28, 2016
90%: working multiple queues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets resque-web to work with multiple failure queues when using the 1.25.2 API with a fix around multiple failure queue backends (resque/resque#1234)
This isn't tested with the resque 2.0 API, especially around the retrying of all jobs due to requeue_and_remove not accepting a queue name parameter.
Currently the Gemfile specifies the talis fork of resque, however, once the multiple failure queue backend fix has been merged in, this should be good to use with mainline resque.