Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toasts): increase z-index to sit above modals #12

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

camillef
Copy link

@camillef camillef commented Nov 2, 2021

Problem

Our toasts do not have a z-index and so sit behind modals and other components with a z-index, such as pagination controls (the active page-link gets a z-index of 3: twbs/bootstrap#28784)

Before

image

image

Fix

Set our toast-container's z-index to $zindex-popover which means it sits above modals but below tooltips in the zindex scale

$zindex-dropdown:                   1000 !default;
$zindex-sticky:                     1020 !default;
$zindex-fixed:                      1030 !default;
$zindex-offcanvas-backdrop:         1040 !default;
$zindex-offcanvas:                  1045 !default;
$zindex-modal-backdrop:             1050 !default;
$zindex-modal:                      1055 !default;
$zindex-popover:                    1070 !default;
$zindex-tooltip:                    1080 !default;

After

image

image

@camillef camillef merged commit 12652fb into main Nov 2, 2021
@camillef camillef deleted the increase-toast-zindex branch November 2, 2021 16:29
@danielmatthew
Copy link
Contributor

@camillef How urgently do you need this? I've got a couple of patches lined up and would like to bundle them into a single release over the next couple of days.

@camillef
Copy link
Author

camillef commented Nov 2, 2021

@danielmatthew No rush - I doubt anyone's noticed but me :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants