Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distribution): add Nix Flake based duckdb shared library + jar output #15

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

thenonameguy
Copy link
Contributor

@thenonameguy thenonameguy commented Jan 31, 2024

Hey, thanks for the great library!

For ease of use, I added a Nix-based slim jar distribution method for my own purposes.
Would be happy to upstream the change, if you don't think it pollutes the repo too much. ✌️

flake.nix Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cnuernber
Copy link
Collaborator

This is great - people like to have the binaries in the jar as it simplifies other things. I'm going to merge this assuming it doesn't break other things such as the existing scripts/deploy pathway. My guess is you will often have to rebuild the lockfile as we aren't currently using nix here.

@cnuernber cnuernber merged commit 6dcd76a into techascent:main Feb 13, 2024
@thenonameguy thenonameguy deleted the nix-flake branch February 13, 2024 13:05
@thenonameguy
Copy link
Contributor Author

thenonameguy commented Feb 13, 2024

Thanks for merging! 🙏

There actually exists an automated solution via Github Actions that opens a PR to keep the lockfile in sync:
https://jlesquembre.github.io/clj-nix/github-action/

I'll use the this repo now, instead of my fork.
I'll open a PR next time I upgrade it so the above is set up, without much manual intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants