Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for null trades, and fix the same issue with orders #13

Merged
merged 3 commits into from
Dec 7, 2017
Merged

Test for null trades, and fix the same issue with orders #13

merged 3 commits into from
Dec 7, 2017

Conversation

mithrandi
Copy link
Collaborator

Looks like PrivateOrders has the same issue where Luno will return null instead of an empty list.

@tebello-thejane tebello-thejane merged commit a4a6a3d into tebello-thejane:master Dec 7, 2017
@tebello-thejane
Copy link
Owner

CI is failing because of this issue: commercialhaskell/stack#3624

@tebello-thejane tebello-thejane self-requested a review December 7, 2017 03:44
@mithrandi mithrandi deleted the test-empty-orders branch December 21, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tebello-thejane tebello-thejane Awaiting requested review from tebello-thejane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mithrandi @tebello-thejane