feat: modify Client API to place variables in last positional argument. #226
+360
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
Nice! I didn't think we'd get to parity this quickly. I really enjoy the variables change since it makes natural since. It hasn't been that popular in reason to put an unlabelled required argument last but I've hoped for a long time it'd become more favoured as it's very natural 👏
parkerziegler
force-pushed
the
feature/modify-client-api
branch
from
e53982c to
5019446
Compare
parkerziegler
added a commit
that referenced
this pull request
Nov 12, 2020
parkerziegler
added a commit
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
ClientAPIs:~requestlabeled argument is renamed to~query,~mutation, or~subscriptiondepending on the method in use.variablesare passed as records in the last position, if required. If the query, mutation, or subscription uses no variables,unitis passed in the last position.urqlpeerDependencyintroduced in Make urql a peerDependency. Update examples to use pure CSS. #224Clientdocumentation to match the latest API changes.operationNametokindper this PR inurqlupstream.Alongside #225 we're getting very close to a usable
v3! Moving slowly here but hoping to keep plugging away at everything while I also balance grad school apps this weekend 🤦