-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fragment parse and serialize implementation does not match module signature #296
Comments
illusionalsagacity
added a commit
to illusionalsagacity/graphql-ppx
that referenced
this issue
Oct 11, 2024
resolves teamwalnut#296 the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something?
illusionalsagacity
added a commit
to illusionalsagacity/graphql-ppx
that referenced
this issue
Oct 16, 2024
resolves teamwalnut#296 the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something? re-run tests
illusionalsagacity
added a commit
to illusionalsagacity/graphql-ppx
that referenced
this issue
Oct 16, 2024
resolves teamwalnut#296 the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something? re-run tests
illusionalsagacity
added a commit
to illusionalsagacity/graphql-ppx
that referenced
this issue
Oct 16, 2024
resolves teamwalnut#296 the module signature was not wrapped, and the implementation was wrapped in another fun that prevented the match in wrap_as_uncurried_fn from working as intended I also fixed a warning 53 with the @@tailcall attribute I was getting for ocaml 5.1.1, maybe I ended up with different versions of something? re-run tests
illusionalsagacity
changed the title
Fragment parse and serialize functions are not marked as uncurried
Fragment parse and serialize implementation does not match module signature
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using
[email protected]
,@reasonml-community/[email protected]
, and a WIP branch forrescript-apollo-client
with thesebsconfig.json
settings:The
Fragments.res
module's definitions forparse
andserialize
are not marked as uncurried functions:This seems to be that generate_fragment_signature doesn't use
wrap_sig_uncurried_fn
for these, likegenerate_operation_signature
does.The text was updated successfully, but these errors were encountered: