Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all the things #4

Merged
merged 13 commits into from
Sep 9, 2020
Merged

Fix all the things #4

merged 13 commits into from
Sep 9, 2020

Conversation

chbonser
Copy link

@chbonser chbonser commented Sep 9, 2020

  • Fix 'Invalid Version' error by hardening the version comparison function. It now pushes invalid versions to the end (earliest) version instead of throw an exception and crashing the app.
  • Replace deprecated lodash includes with contains
  • Adjust server setup to only terminate https when the HTTPS_KEY variable is set
  • Add a yarn.lock file because deploying a production server without a lock file is too great a security risk
  • Add a Procfile so heroku uses the right command to run the app
  • Wrap the the launch script bin/web.js in a try catch block so tailing the log provides an error and backtrace when it fails
  • Replace the urljoin.js package with the more used url-join package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant