Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove backup mechanism #76

Merged
merged 2 commits into from
Nov 18, 2024
Merged

remove backup mechanism #76

merged 2 commits into from
Nov 18, 2024

Conversation

alisterburt
Copy link
Member

@alisterburt alisterburt commented Nov 18, 2024

this PR removes the backup mechanism as a fix for #72

@jojoelfe I went with removing here but please drop a comment if you'd much rather keep the backup mechanism - from my side I see it as useful for user facing applications but shouldn't be in a lower level utility like starfile

will merge if I don't hear back from you soon :-)

@alisterburt alisterburt requested a review from jojoelfe November 18, 2024 18:23
Copy link
Collaborator

@jojoelfe jojoelfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (5b19406) to head (9f7d5b4).
Report is 22 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   80.93%   82.27%   +1.33%     
==========================================
  Files           7        7              
  Lines         278      299      +21     
==========================================
+ Hits          225      246      +21     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alisterburt alisterburt merged commit 30877a0 into main Nov 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants