Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unnecessary line skip #73

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

jdickerson95
Copy link
Member

Is there any reason for this extra line skip?
It prevents being able to read star files that don't have an empty line between the data_ and loop_ lines (e.g. relion mtf star files)

@alisterburt
Copy link
Member

Good catch! If it doesn't break anything else let's get this merged - have approved the CI run and will check back tomorrow

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.73%. Comparing base (5b19406) to head (658b0e8).
Report is 19 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   80.93%   82.73%   +1.80%     
==========================================
  Files           7        7              
  Lines         278      307      +29     
==========================================
+ Hits          225      254      +29     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisterburt alisterburt merged commit 36728a8 into teamtomo:main Nov 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants