Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

Consider removing multi_json dependency #733

Closed
yob opened this issue Feb 13, 2016 · 3 comments
Closed

Consider removing multi_json dependency #733

yob opened this issue Feb 13, 2016 · 3 comments

Comments

@yob
Copy link
Contributor

yob commented Feb 13, 2016

Hi,

JSON has been part of the ruby stdlib since 1.9.0 (see ruby/ruby@af1c4167), and the latest version of poltegeist requires ruby 1.9.3 or better.

Would you consider removing multi_json as a dependency, and just using require 'json' instead? Rails recently made a similar change (rails/rails#23453), which has prompted other libraries to consider the same issue (like simplecov and stripe).

See also this recent blog post.

Thanks for a great library!

@route
Copy link
Contributor

route commented Feb 13, 2016

Sounds good! Mind opening a PR?

@yob
Copy link
Contributor Author

yob commented Feb 13, 2016

Sure, I've opened #734

@route
Copy link
Contributor

route commented Feb 13, 2016

Thank you!

@route route closed this as completed Feb 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants