-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropping json gem dependency #458
Comments
My take: if it's causing us problems we should drop EOL versions. (I also just recently hit issues in a different project because of similar issues with |
I second that, I think we should get rid of support for EOL'd rubies. On the 2.x-vresions of Ruby I've personally not seen any upgrade issues anyway, so now that 2.0 is getting EOL'd this month it might even make sense to drop support for that too. |
Somewhat related as to supporting outdated rubies: A minor compatibility issue came up that breaks simplecov for 1.9.3, which EOL'd around a year ago: https://github.com/colszowka/simplecov/pull/448/files#r52411167 |
my personal take on this: what just came to my mind. maybe this can also simplify the rails integration? never versions of Rails are pretty hardcore at dropping older ruby versions. (AFAIK Rails 5 will only run on 2.2 and higher?) i will prepare a PR that removes the |
Just dropepd support of old rubies and of the JSON gem. |
hello simplecov-contributors!
just out of interest, how important is supporting really really really old rubies for simplecov?
i recently saw this tweet from Mike Perham (rails/rails#23453) and started looking at our Gemfiles. some of the projects only use simplecov and therefor a quite significant amount of gem dependencies.
dropping the json is just one example and it's only a minor code change, it's almost a philosophical question and there is no right or wrong. there are opinions. i'm interested in the opinion of you, the simplecov contributors.
thanks for simplecov!
ben
The text was updated successfully, but these errors were encountered: