fix: fix email verified check for saml #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the email_verified check in the Hanko SAML provider.
Implementation
Currently it is only check if the field in the SAML response is not an empty string, but when the SAML provider returns
falsefor the email_verified field the Hanko SAML provider interprets it astrue. Now it check if the value istrueand when it is not, the email_verified field in Hanko will be set tofalse.Tests
E.g. Use the quickstart app and setup SAML in hanko and login with an user which email is not verified and check in the profile that the email is not verified.