-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: migrate from pipenv to poetry #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember also to update the CI/CD pipelines in the cloudbuild
directory to use a python:3.9
image
all pipfile.lock files have been deleted and replaced with poetry.lock files
… directory to use a python:3.9 image
@roberta-dt you will also need to update the Makefile to change all the |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @roberta-dt for your contribution! Approved.
/gcbrun |
Description
Moved from
pipenv
topoetry
for Python dependency management, and upgraded the Python version to 3.9 ahead of Python 3.7 EOLHow has this been tested?
make
commands tested manuallyAutomated tests all passing
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature works