Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: migrate from pipenv to poetry #13

Merged
merged 61 commits into from
Jun 2, 2023
Merged

Conversation

roberta-dt
Copy link
Collaborator

@roberta-dt roberta-dt commented May 16, 2023

Description

Moved from pipenv to poetry for Python dependency management, and upgraded the Python version to 3.9 ahead of Python 3.7 EOL

How has this been tested?

make commands tested manually
Automated tests all passing

Checklist

- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have successfully run the E2E tests
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

@roberta-dt roberta-dt requested a review from a user May 16, 2023 08:36
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember also to update the CI/CD pipelines in the cloudbuild directory to use a python:3.9 image

components/bigquery-components/pyproject.toml Outdated Show resolved Hide resolved
components/vertex-components/pyproject.toml Outdated Show resolved Hide resolved
components/bigquery-components/pyproject.toml Outdated Show resolved Hide resolved
components/vertex-components/pyproject.toml Outdated Show resolved Hide resolved
pipelines/pyproject.toml Outdated Show resolved Hide resolved
pipelines/pyproject.toml Outdated Show resolved Hide resolved
pipelines/pyproject.toml Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
@ghost ghost changed the base branch from main to develop May 17, 2023 13:10
@ghost ghost force-pushed the feature/add-poetry branch from f884a49 to 2f44007 Compare May 17, 2023 13:11
components/vertex-components/pyproject.toml Outdated Show resolved Hide resolved
pipelines/pyproject.toml Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 23, 2023

@roberta-dt you will also need to update the Makefile to change all the pipenv commands to poetry commands

@roberta-dt roberta-dt marked this pull request as ready for review May 25, 2023 16:43
@teamdatatonic teamdatatonic deleted a comment Jun 2, 2023
@teamdatatonic teamdatatonic deleted a comment Jun 2, 2023
@felix-datatonic
Copy link
Collaborator

/gcbrun

@felix-datatonic felix-datatonic dismissed ghost ’s stale review June 2, 2023 07:36

I'll review this PR instead.

@felix-datatonic felix-datatonic self-requested a review June 2, 2023 07:36
@teamdatatonic teamdatatonic deleted a comment from roberta-dt Jun 2, 2023
felix-datatonic
felix-datatonic previously approved these changes Jun 2, 2023
Copy link
Collaborator

@felix-datatonic felix-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @roberta-dt for your contribution! Approved.

README.md Show resolved Hide resolved
pipelines/pyproject.toml Show resolved Hide resolved
@ariadnafer
Copy link

/gcbrun

@felix-datatonic felix-datatonic self-requested a review June 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants