Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset with data url #1215

Closed
wants to merge 2 commits into from
Closed

Reset with data url #1215

wants to merge 2 commits into from

Conversation

jnicklas
Copy link
Collaborator

Reset page with data-urls. This should solve problems with remote drivers not being able to access empty page, and also with Windows not understanding the file:// protocol properly.

Jonas Nicklas and Kim Burgestrand added 2 commits December 20, 2013 10:27
closes #1035
closes #1214
closes #1203
closes #1198

Since it does not work with remote drivers, and somehow screws up on Windows.
@DylanLacey
Copy link

👍

DylanLacey added a commit to DylanLacey/sauce_ruby that referenced this pull request Dec 30, 2013
@ghost
Copy link

ghost commented Dec 30, 2013

cool trick! :)

@jnicklas jnicklas closed this in 03ec848 Jan 6, 2014
jnicklas added a commit that referenced this pull request Jan 6, 2014
closes #1035
closes #1214
closes #1203
closes #1198
closes #1215

Since it does not work with remote drivers, and somehow screws up on Windows.
juliemr added a commit to juliemr/protractor that referenced this pull request May 20, 2014
As documented at teamcapybara/capybara#1215
there are sometimes issues with webdriver and about:blank pages.

Switching instead to try a data url.

This has been tried 5x on Travis without any flakes.
@juliemr
Copy link

juliemr commented May 21, 2014

PSA for anyone looking at this in the future, the data URI is great but doesn't work with internet explorer.

@twalpole twalpole deleted the reset-with-data-url branch November 12, 2018 18:10
bodyduardU pushed a commit to bodyduardU/protractor that referenced this pull request Dec 5, 2022
As documented at teamcapybara/capybara#1215
there are sometimes issues with webdriver and about:blank pages.

Switching instead to try a data url.

This has been tried 5x on Travis without any flakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants